lease: modify log info #7701
lease: modify log info #7701
Conversation
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
the
release-note-none
ti-chi-bot
bot
added
the
size/XS
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7701 +/- ##
==========================================
- Coverage 70.00% 69.98% -0.02%
==========================================
Files 430 430
Lines 47637 47641 +4
==========================================
- Hits 33349 33343 -6
Misses 11542 11542
- Partials 2746 2756 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
pkg/election/lease.go
Outdated
| @@ -135,7 +135,7 @@ func (l *lease) KeepAlive(ctx context.Context) { | |||
| // https://pkg.go.dev/time@master#Timer.Reset | |||
| timer.Reset(l.leaseTimeout) | |||
| case <-timer.C: | |||
| log.Info("lease timeout", zap.Time("expire", l.expireTime.Load().(time.Time)), zap.String("purpose", l.Purpose)) | |||
| log.Info("keep alive lease too slow", zap.Duration("timeout duration", l.leaseTimeout), zap.Time("actual-expire", l.expireTime.Load().(time.Time)), zap.String("purpose", l.Purpose)) | |||
There was a problem hiding this comment.
| log.Info("keep alive lease too slow", zap.Duration("timeout duration", l.leaseTimeout), zap.Time("actual-expire", l.expireTime.Load().(time.Time)), zap.String("purpose", l.Purpose)) | |
| log.Info("keep alive lease too slow", zap.Duration("timeout-duration", l.leaseTimeout), zap.Time("actual-expire", l.expireTime.Load().(time.Time)), zap.String("purpose", l.Purpose)) |
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
ti-chi-bot
bot
added
size/S
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
| go func() { | ||
| start := time.Now() | ||
| if start.Sub(lastTime) > interval*2 { | ||
| log.Warn("the interval between keeping alive lease is too long", zap.Time("last-time", lastTime)) |
There was a problem hiding this comment.
It's possible. But similar to the 'clock offset' warning log in tso, it is indeed a worthwhile log to output
ti-chi-bot
bot
added
status/LGT2
|
/merge |
|
@disksing: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 1441cc4
|
ti-chi-bot
bot
added
the
status/can-merge
|
@CabinfeverB: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #7700
What is changed and how does it work?
modify log message add some fields.
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tiup:Release note